-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
state also in the intro that UnsafeCell has no effect on &mut #62716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @Kimundi (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jul 16, 2019
@Centril could you review this? It's a tiny patch. :) |
Thanks! @bors r+ rollup |
📌 Commit d30b36e has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jul 24, 2019
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 24, 2019
state also in the intro that UnsafeCell has no effect on &mut Just to be extra sure.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 24, 2019
Rollup of 10 pull requests Successful merges: - rust-lang#62641 (Regenerate character tables for Unicode 12.1) - rust-lang#62716 (state also in the intro that UnsafeCell has no effect on &mut) - rust-lang#62738 (Remove uses of mem::uninitialized from std::sys::cloudabi) - rust-lang#62772 (Suggest trait bound on type parameter when it is unconstrained) - rust-lang#62890 (Normalize use of backticks in compiler messages for libsyntax/*) - rust-lang#62905 (Normalize use of backticks in compiler messages for doc) - rust-lang#62916 (Add test `self-in-enum-definition`) - rust-lang#62917 (Always emit trailing slash error) - rust-lang#62926 (Fix typo in mem::uninitialized doc) - rust-lang#62927 (use PanicMessage in MIR, kill InterpError::description) Failed merges: r? @ghost
bors
added a commit
that referenced
this pull request
Jul 24, 2019
Rollup of 10 pull requests Successful merges: - #62641 (Regenerate character tables for Unicode 12.1) - #62716 (state also in the intro that UnsafeCell has no effect on &mut) - #62738 (Remove uses of mem::uninitialized from std::sys::cloudabi) - #62772 (Suggest trait bound on type parameter when it is unconstrained) - #62890 (Normalize use of backticks in compiler messages for libsyntax/*) - #62905 (Normalize use of backticks in compiler messages for doc) - #62916 (Add test `self-in-enum-definition`) - #62917 (Always emit trailing slash error) - #62926 (Fix typo in mem::uninitialized doc) - #62927 (use PanicMessage in MIR, kill InterpError::description) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to be extra sure.